Refactor $size event behavior #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace interval-based size update with a ResizeObserver instance - Use the body element to measure size, to avoid issues that come with using the document element - Add "overflow:scroll" to the View widget content holder element
|
arnaugiralt
requested review from
irinanic88,
nerimartinez,
paulinaczybir,
riazhski,
theConscience and
victor-cuevas
maxipavlovic
approved these changes
Feb 23, 2024
| if (type === '$size') { | ||
| const { height, width } = document.body.getBoundingClientRect(); | ||
| data = { height, width }; | ||
| } |
theConscience
approved these changes
Feb 23, 2024
riazhski
approved these changes
Feb 23, 2024
paulinaczybir
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several things are sub-par in the current implementation:
$sizeevent is triggered using an intervalThis PR refactors the way we trigger the
$sizeevent and how we calculate the size itself:ResizeObserverinstance.Also added
"overflow:scroll"to the View widget's content holder element, so we have a behaviour more in line with the Connect SPA.These changes are backwards compatible, since there is no external API to mess with the
$sizeevent, so no need to update the major version after this is merged.